Update terraform provider openstack to v3 #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd109
force-pushed
the
update/tf-provider-openstack
branch
from
e5ff728 to
839e45d
Compare
sjpb
requested changes
Feb 19, 2025
Collaborator
sjpb
left a comment
sjpb
left a comment
There was a problem hiding this comment.
Can you update the other hits for this too please:
$ grep -r required_providers environments/
environments/.stackhpc/tofu/main.tf: required_providers {
environments/skeleton/{{cookiecutter.environment}}/tofu/main.tf: required_providers {
environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/main.tf: required_providers {
Collaborator
|
I cancelled the tests b/c the current PR changes don't actually affect the CI environment |
Collaborator
|
@sd109 I'm still interested in getting this in, see comment above. |
sd109
force-pushed
the
update/tf-provider-openstack
branch
from
d322eef to
8230b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK the comment regarding
openstack_compute_floatingip_associate_v2is no longer applicable so I think we can try to upgrade? I don't think we're using any of the other removed resource types listed here so shouldn't require any other changes in the appliance https://registry.terraform.io/providers/terraform-provider-openstack/openstack/latest/docs/guides/upgrade-guide-version-3